cstamas commented on code in PR #1413:
URL: https://github.com/apache/maven/pull/1413#discussion_r1492417751
##########
maven-core/src/main/java/org/apache/maven/bridge/MavenRepositorySystem.java:
##########
@@ -653,7 +653,7 @@ public ArtifactRepository
createLocalRepository(MavenExecutionRequest request, F
public ArtifactRepository createLocalRepository(File localRepository)
throws InvalidRepositoryException {
return createRepository(
- "file://" + localRepository.toURI().getRawPath(),
+ localRepository.toURI().toASCIIString(),
Review Comment:
If you are on Win, you should reproduce this just by checking out this PR,
as Resolver on this PR is 'locked snapshot' so you would get the very same
thing that CI builds.
##########
maven-core/src/main/java/org/apache/maven/bridge/MavenRepositorySystem.java:
##########
@@ -653,7 +653,7 @@ public ArtifactRepository
createLocalRepository(MavenExecutionRequest request, F
public ArtifactRepository createLocalRepository(File localRepository)
throws InvalidRepositoryException {
return createRepository(
- "file://" + localRepository.toURI().getRawPath(),
+ localRepository.toURI().toASCIIString(),
Review Comment:
If you are on Win, you could reproduce this just by checking out this PR, as
Resolver on this PR is 'locked snapshot' so you would get the very same thing
that CI builds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
