[ 
https://issues.apache.org/jira/browse/MCOMPILER-570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17820363#comment-17820363
 ] 

ASF GitHub Bot commented on MCOMPILER-570:
------------------------------------------

kwin opened a new pull request, #224:
URL: https://github.com/apache/maven-compiler-plugin/pull/224

   Further cleanup of javadoc
   
   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
    - [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/MCOMPILER) filed 
          for the change (usually before you start working on it).  Trivial 
changes like typos do not 
          require a JIRA issue.  Your pull request should address just this 
issue, without 
          pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line 
and body.
    - [ ] Format the pull request title like `[MCOMPILER-XXX] - Fixes bug in 
ApproximateQuantiles`,
          where you replace `MCOMPILER-XXX` with the appropriate JIRA issue. 
Best practice
          is to use the JIRA issue title in the pull request title and in the 
first line of the 
          commit message.
    - [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
    - [ ] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will 
          be performed on your pull request automatically.
    - [ ] You have run the integration tests successfully (`mvn -Prun-its clean 
verify`).
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
    - [ ] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
    - [ ] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   




> Javadoc: Add link to javac references from JDK17
> ------------------------------------------------
>
>                 Key: MCOMPILER-570
>                 URL: https://issues.apache.org/jira/browse/MCOMPILER-570
>             Project: Maven Compiler Plugin
>          Issue Type: Improvement
>            Reporter: Konrad Windszus
>            Assignee: Konrad Windszus
>            Priority: Major
>             Fix For: next-release
>
>
> Similar to what was done in MJAVADOC-729 all plugin parameters which are more 
> or less passed as is to the underlying {{javac}} tool should have a link in 
> their javadoc to the according Oracle documentation for javac from JDK17 
> (https://docs.oracle.com/en/java/javase/17/docs/specs/man/javac.html).
> Although it depends a bit on the underlying compiler being used, the most 
> common combination is with 
> https://codehaus-plexus.github.io/plexus-compiler/plexus-compilers/plexus-compiler-javac/
>  which either calls {{javac}} via commandline or via 
> {{com.sun.tools.javac.Main}} which share the same semantics for the arguments.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to