[
https://issues.apache.org/jira/browse/MCOMPILER-577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17820664#comment-17820664
]
ASF GitHub Bot commented on MCOMPILER-577:
------------------------------------------
kwin opened a new pull request, #225:
URL: https://github.com/apache/maven-compiler-plugin/pull/225
Clarify meaning in javadoc
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MCOMPILER) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line
and body.
- [ ] Format the pull request title like `[MCOMPILER-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `MCOMPILER-XXX` with the appropriate JIRA issue.
Best practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its clean
verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
> Rename parameter "forceJavacCompilerUse"
> ----------------------------------------
>
> Key: MCOMPILER-577
> URL: https://issues.apache.org/jira/browse/MCOMPILER-577
> Project: Maven Compiler Plugin
> Issue Type: Improvement
> Reporter: Konrad Windszus
> Assignee: Konrad Windszus
> Priority: Major
> Fix For: next-release
>
>
> The name {{forceJavacCompilerUse}}
> (https://maven.apache.org/plugins/maven-compiler-plugin/compile-mojo.html#forceJavacCompilerUse)
> is confusing, because it only determines which API to use to access
> {{javac}}, but doesn't actually affect the compiler being used (which is
> determined via {{compilerId}} or toolchains).
> I would propose to rename that to {{forceLegacyJavacApi}} and clarify that
> this currently only has an effect on compiler {{javac}} (in case it is not
> forked). In order to be backwards-compatible the old name should still be
> considered as alias.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
