kwin commented on code in PR #1421:
URL: https://github.com/apache/maven/pull/1421#discussion_r1506296544
##########
maven-model-builder/src/main/java/org/apache/maven/model/profile/activation/OperatingSystemProfileActivator.java:
##########
@@ -53,17 +57,21 @@ public boolean isActive(Profile profile,
ProfileActivationContext context, Model
boolean active = ensureAtLeastOneNonNull(os);
+ String actualOsName =
context.getSystemProperties().get("os.name").toLowerCase(Locale.ENGLISH);
Review Comment:
Compare with
https://github.com/apache/maven/blob/ab6ec5bd74af20ab429509eb56fc8e3dff4c7fc7/maven-model-builder/src/main/java/org/apache/maven/model/profile/activation/JdkVersionProfileActivator.java#L64
and
https://github.com/apache/maven/blob/ab6ec5bd74af20ab429509eb56fc8e3dff4c7fc7/maven-model-builder/src/test/java/org/apache/maven/model/profile/activation/JdkVersionProfileActivatorTest.java#L50
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
