[
https://issues.apache.org/jira/browse/SUREFIRE-2240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17823620#comment-17823620
]
ASF GitHub Bot commented on SUREFIRE-2240:
------------------------------------------
kwin opened a new pull request, #725:
URL: https://github.com/apache/maven-surefire/pull/725
This allows to more easily overwrite the version via plugin dependencies
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/SUREFIRE) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line
and body.
- [ ] Format the pull request title like `[SUREFIRE-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `SUREFIRE-XXX` with the appropriate JIRA issue.
Best practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [ ] Run `mvn clean install` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its clean
install`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
> Using JUnit BOM prevents upgrading the engine version
> -----------------------------------------------------
>
> Key: SUREFIRE-2240
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2240
> Project: Maven Surefire
> Issue Type: Bug
> Components: JUnit 5.x support
> Affects Versions: 3.2.1
> Reporter: Konrad Windszus
> Priority: Major
>
> The change being introduced in SUREFIRE-2177 prevents updating the
> {{junit-jupiter-engine}} through explicit plugin dependencies as outlined in
> https://maven.apache.org/surefire/maven-surefire-plugin/examples/junit-platform.html#select-engine-and-use-multiple-apis:
> {code}
> <plugin>
> <artifactId>maven-surefire-plugin</artifactId>
> <dependencies>
> <dependency>
> <groupId>org.junit.jupiter</groupId>
> <artifactId>junit-jupiter-engine</artifactId>
> <version>5.10.2</version>
> </dependency>
> </dependencies>
> </plugin>
> {code}
> The following classpath is then used in m-surefire-p
> {code}
> [INFO] --- surefire:3.2.2:test (default-test) @ doxia-converter ---
> [DEBUG] Dependency collection stats {ConflictMarker.analyzeTime=62708,
> ConflictMarker.markTime=28792, ConflictMarker.nodeCount=94,
> ConflictIdSorter.graphTime=19292, ConflictIdSorter.topsortTime=17458,
> ConflictIdSorter.conflictIdCount=48, ConflictIdSorter.conflictIdCycleCount=0,
> ConflictResolver.totalTime=382250, ConflictResolver.conflictItemCount=92,
> DfDependencyCollector.collectTime=35588250,
> DfDependencyCollector.transformTime=530209}
> [DEBUG] org.apache.maven.plugins:maven-surefire-plugin:jar:3.2.2
> [DEBUG] org.junit.jupiter:junit-jupiter-engine:jar:5.10.2:runtime
> [DEBUG] org.junit.platform:junit-platform-engine:jar:1.9.3:runtime
> (version managed from default)
> ...
> {code}
> The managed {{junit-platform-engine}} version is incompatible (as being
> downgraded via
> https://github.com/apache/maven-surefire/blob/2fed802397f8c7de4cfc72f49ab4565e72f7aab7/pom.xml#L311-L318)
> For this reason there shouldn't be any depMgmt used in surefire.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
