[ 
https://issues.apache.org/jira/browse/MSITE-1002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17825095#comment-17825095
 ] 

Konrad Windszus edited comment on MSITE-1002 at 3/10/24 7:28 PM:
-----------------------------------------------------------------

This regular expression does not match doxia v2 output which should add the 
necessary {{prettyprint}} class: 
https://github.com/apache/maven-fluido-skin/blob/59b104d843e65eed6023d192b95f875e1e0e2b0a/src/main/resources/META-INF/maven/site.vm#L246.

For Doxia v1 the regular expression from Fluido 1.x matches though: 
https://github.com/apache/maven-fluido-skin/blob/32835a68dbf391198a4da10582f9908277d24309/src/main/resources/META-INF/maven/site.vm#L251

This is a regression of 
https://github.com/apache/maven-fluido-skin/commit/c093ebf06ae8d60cb3947dbf0bec3d05d4313c73
 (MSKINS-221) [~michael-o] Why do you expect a div now with both classes 
{{verbatim}} and {{source}}? This does not reflect reality (at least not for 
this markdown source: 
https://github.com/awxiaoxian2020/code-render-bug/blob/964ca90272fa95e8c2996e6f439122bce54eb1ef/src/site/markdown/test.md?plain=1#L1)


was (Author: kwin):
This regular expression does not match doxia v2 output which should add the 
necessary {{prettyprint}} class: 
https://github.com/apache/maven-fluido-skin/blob/59b104d843e65eed6023d192b95f875e1e0e2b0a/src/main/resources/META-INF/maven/site.vm#L246.

For Doxia v1 the regular expression from Fluido 1.x matches though: 
https://github.com/apache/maven-fluido-skin/blob/32835a68dbf391198a4da10582f9908277d24309/src/main/resources/META-INF/maven/site.vm#L251

This is a regression of 
https://github.com/apache/maven-fluido-skin/commit/c093ebf06ae8d60cb3947dbf0bec3d05d4313c73
 (MSKINS-221) [~michael-o] Why do you expect a div now with both classes 
{{verbatim}} and {{source}}? This does not reflect reality....

> Maven Site 4 will break code highlight of site generated by Markdown
> --------------------------------------------------------------------
>
>                 Key: MSITE-1002
>                 URL: https://issues.apache.org/jira/browse/MSITE-1002
>             Project: Maven Site Plugin
>          Issue Type: Bug
>          Components: doxia integration
>    Affects Versions: 4.0.0-M13
>            Reporter: Xavi Lee
>            Assignee: Michael Osipov
>            Priority: Major
>         Attachments: maven-site-3.png, maven-site-4.png, test-v3.html, 
> test-v4.html
>
>
> repro repo https://github.com/awxiaoxian2020/code-render-bug
> master branch is Maven Site 3 with Fluido skin 1
> v4 branch is Maven Site 4 with Fluido skin 2.
> Open their respective `target/site/test.html` files in local to see the 
> rendered result.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to