michael-o commented on code in PR #204:
URL: https://github.com/apache/maven-doxia/pull/204#discussion_r1525401870


##########
doxia-core/src/main/java/org/apache/maven/doxia/parser/Xhtml1BaseParser.java:
##########
@@ -0,0 +1,159 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.doxia.parser;
+
+import java.util.HashMap;
+import java.util.Map;
+import java.util.function.UnaryOperator;
+
+import org.apache.maven.doxia.sink.Sink;
+import org.apache.maven.doxia.sink.impl.SinkEventAttributeSet;
+import org.codehaus.plexus.util.xml.pull.XmlPullParser;
+
+/**
+ * Acts as bridge between legacy parsers relying on <a 
href="https://www.w3.org/TR/xhtml1/";>XHTML 1.0 Transitional (based on HTML4)</a>
+ * and the {@link Xhtml5BaseParser} only supporting (X)HTML5 
elements/attributes.
+ *
+ * Adds support for elements/attributes which <a 
href="https://html.spec.whatwg.org/#non-conforming-features";>became obsolete in 
HTML5</a> but are
+ * commonly used for XDoc/FML.
+ *
+ * @see <a href="https://www.w3.org/TR/html5-diff/";>HTML5 Differences from 
HTML4</a>.
+ */
+public class Xhtml1BaseParser extends Xhtml5BaseParser {
+
+    private static final class AttributeMapping {
+        private final String sourceName;
+        private final String targetName;
+        private final UnaryOperator<String> valueMapper;
+        private final MergeSemantics mergeSemantics;
+
+        enum MergeSemantics {
+            OVERWRITE,
+            IGNORE,
+            PREPEND

Review Comment:
   Do we need append as well?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to