gnodet commented on PR #445: URL: https://github.com/apache/maven-resolver/pull/445#issuecomment-1999632591
I'm *really* reluctant about this PR. This goes in the exact opposite direction than https://issues.apache.org/jira/browse/MRESOLVER-471, which aimed to make the resolver agnostic about scopes and leave these bits to be defined by Maven. It basically replaces 250 lines of deprecated code (the `JavaDependencyContextRefiner`, `JavaScopeDeriver` and `JavaScopeSelector` which were deprecated a few weeks ago) with 3800 new lines of code, adds a strong tie between the resolver and maven, whereas the code could be easily moved into maven which already exposes those concepts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
