[
https://issues.apache.org/jira/browse/DOXIA-731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17827670#comment-17827670
]
ASF GitHub Bot commented on DOXIA-731:
--------------------------------------
michael-o commented on code in PR #202:
URL: https://github.com/apache/maven-doxia/pull/202#discussion_r1527133853
##########
doxia-modules/doxia-module-markdown/src/test/java/org/apache/maven/doxia/module/markdown/MarkdownParserTest.java:
##########
@@ -798,4 +800,24 @@ public void testQuoteVsApostrophe() throws Exception {
"This apostrophe isn't a quote." + "This \u2018quoted
text\u2019 isn't surrounded by apostrophes.",
content.toString());
}
+
+ @Override
+ protected void assertEventPrefix(Iterator<SinkEventElement> eventIterator)
{
+ assertSinkStartsWith(eventIterator, "head", "head_", "body");
+ }
+
+ @Override
+ protected void assertEventSuffix(Iterator<SinkEventElement> eventIterator)
{
+ assertSinkEquals(eventIterator, "body_");
+ }
+
+ @Override
+ protected String getVerbatimSource() {
+ return null; // not supported in MD
Review Comment:
This isn't what a meant. I meant just add the link I have provided and
explain why we return null since this is not a missing/broken test.
> Simplify HTML emitted from Sink.verbatim(...)
> ---------------------------------------------
>
> Key: DOXIA-731
> URL: https://issues.apache.org/jira/browse/DOXIA-731
> Project: Maven Doxia
> Issue Type: Improvement
> Components: Core
> Affects Versions: 2.0.0-M9
> Reporter: Konrad Windszus
> Assignee: Konrad Windszus
> Priority: Major
>
> The XHTML markup generated from Sink.verbatim(...) should be streamlined to
> either emit {{<pre>}} or {{<pre><code>}} depending on the given attribute.
> There is no need to generate an additional div nor any additional classes.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
