elharo commented on code in PR #1435:
URL: https://github.com/apache/maven/pull/1435#discussion_r1527655423
##########
maven-embedder/src/main/java/org/apache/maven/cli/event/ExecutionEventLogger.java:
##########
@@ -243,10 +246,44 @@ public void projectSkipped(ExecutionEvent event) {
if (logger.isInfoEnabled()) {
logger.info("");
infoLine('-');
+ MavenSession session = event.getSession();
+ MavenExecutionResult result = session.getResult();
+ ProjectDependencyGraph projectDependencyGraph =
session.getProjectDependencyGraph();
+ List<MavenProject> upstreamProjects;
+ if
(MavenExecutionRequest.REACTOR_FAIL_AT_END.equals(session.getReactorFailureBehavior())
+ && projectDependencyGraph != null) {
+
+ // the project is blacklisted only so one of its upstreams
must have failed here...
+ upstreamProjects =
projectDependencyGraph.getUpstreamProjects(event.getProject(), true);
+ } else {
+ // any other failure must have lead to this so any projects is
eligible
Review Comment:
are eligible
##########
maven-embedder/src/main/java/org/apache/maven/cli/event/ExecutionEventLogger.java:
##########
@@ -243,10 +246,44 @@ public void projectSkipped(ExecutionEvent event) {
if (logger.isInfoEnabled()) {
logger.info("");
infoLine('-');
+ MavenSession session = event.getSession();
+ MavenExecutionResult result = session.getResult();
+ ProjectDependencyGraph projectDependencyGraph =
session.getProjectDependencyGraph();
+ List<MavenProject> upstreamProjects;
+ if
(MavenExecutionRequest.REACTOR_FAIL_AT_END.equals(session.getReactorFailureBehavior())
+ && projectDependencyGraph != null) {
+
+ // the project is blacklisted only so one of its upstreams
must have failed here...
Review Comment:
I can't quite follow this comment, please rephrase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
