gnodet commented on PR #242: URL: https://github.com/apache/maven-plugin-tools/pull/242#issuecomment-2012104803
> > The plugin currently supports building either a Maven 3 or a Maven 4 plugin. > > sorry, I still need some explanations because I can't guess from this PR touching 75 files described as "Upgrade to Maven 4.0.0-alpha-12" Most of the 75 files are just a renaming of the `mavenVersion` to `maven3Version` to make it more intuitive which one is used. > > is this PR about adding support for Maven 4 specific plugins in addition to classical Maven 3 plugins? or just upgrading such a support added before that I overlooked? The support was added quite some time ago (https://github.com/apache/maven-plugin-tools/commit/50482ba4695f2e3efe710a583a639fa53dbabb64). This PR is just to upgrade to alpha-13 (and needs to be adjusted with the release) > Is there a Maven 4 plugin IT to look at such a Maven 4 plugin? Yes, there's one at https://github.com/apache/maven-plugin-tools/tree/5297a91a8f8b4df54c96566b0629bb72944c2047/maven-plugin-plugin/src/it/v4api > and key question: is this PR intended for 3.12.0 release, as noted in Jira? Yes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
