gnodet commented on code in PR #448:
URL: https://github.com/apache/maven-resolver/pull/448#discussion_r1543607695
##########
maven-resolver-generator-gnupg/src/main/java/org/eclipse/aether/generator/gnupg/loaders/GpgConfLoader.java:
##########
@@ -66,13 +66,14 @@ public byte[] loadKeyRingMaterial(RepositorySystemSession
session) throws IOExce
GnupgConfigurationKeys.DEFAULT_KEY_FILE_PATH,
GnupgConfigurationKeys.CONFIG_PROP_KEY_FILE_PATH));
if (!keyPath.isAbsolute()) {
- keyPath =
session.getLocalRepository().getBasePath().resolve(keyPath);
+ keyPath =
+
Paths.get(System.getProperty("user.home")).resolve(keyPath).toAbsolutePath();
}
if (Files.isRegularFile(keyPath)) {
if (Files.size(keyPath) < MAX_SIZE) {
return Files.readAllBytes(keyPath);
} else {
- logger.warn("Refusing to load key {}; is larger than 5KB",
keyPath);
+ logger.warn("Refusing to load file {}; is larger than 64KB",
keyPath);
Review Comment:
Ok, that looks really non standard... Honestly, it's the first time I see
this notation. To refer to something we don't care, I'd rather make the
`MAX_SIZE = 64000` just to keep `64 kB`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
