[
https://issues.apache.org/jira/browse/MRESOLVER-516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831963#comment-17831963
]
ASF GitHub Bot commented on MRESOLVER-516:
------------------------------------------
gnodet commented on code in PR #448:
URL: https://github.com/apache/maven-resolver/pull/448#discussion_r1543607695
##########
maven-resolver-generator-gnupg/src/main/java/org/eclipse/aether/generator/gnupg/loaders/GpgConfLoader.java:
##########
@@ -66,13 +66,14 @@ public byte[] loadKeyRingMaterial(RepositorySystemSession
session) throws IOExce
GnupgConfigurationKeys.DEFAULT_KEY_FILE_PATH,
GnupgConfigurationKeys.CONFIG_PROP_KEY_FILE_PATH));
if (!keyPath.isAbsolute()) {
- keyPath =
session.getLocalRepository().getBasePath().resolve(keyPath);
+ keyPath =
+
Paths.get(System.getProperty("user.home")).resolve(keyPath).toAbsolutePath();
}
if (Files.isRegularFile(keyPath)) {
if (Files.size(keyPath) < MAX_SIZE) {
return Files.readAllBytes(keyPath);
} else {
- logger.warn("Refusing to load key {}; is larger than 5KB",
keyPath);
+ logger.warn("Refusing to load file {}; is larger than 64KB",
keyPath);
Review Comment:
Ok, that looks really non standard... Honestly, it's the first time I see
this notation. To refer to something we don't care, I'd rather make the
`MAX_SIZE = 64000` just to keep `64 kB`
> Align GPG signature generator
> -----------------------------
>
> Key: MRESOLVER-516
> URL: https://issues.apache.org/jira/browse/MRESOLVER-516
> Project: Maven Resolver
> Issue Type: Task
> Components: Resolver
> Reporter: Tamas Cservenak
> Assignee: Tamas Cservenak
> Priority: Major
> Fix For: 2.0.0, 2.0.0-alpha-9
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
