rmannibucau commented on PR #30:
URL: 
https://github.com/apache/maven-artifact-plugin/pull/30#issuecomment-2034442739

   > there are 2 runs, look at the first one: no problem with 3.5.1, same 
problem with 3.5.0
   
   Hmm, not sure what which artifact you used built but got back the plugin 
from asf repo and still getting the same error: 
https://gist.github.com/rmannibucau/816c07cd6277e602584d0bb2b4497c5a#file-output-txt-L29
   
   If it helps:
   
   > $ shasum 
~/.m2/repository/org/apache/maven/plugins/maven-artifact-plugin/3.5.1/maven-artifact-plugin-3.5.1.jar
   > c24f8609c90af05fd1fd56c4ad238dacd7fbd791  
/home/rmannibucau/.m2/repository/org/apache/maven/plugins/maven-artifact-plugin/3.5.1/maven-artifact-plugin-3.5.1.jar
   
   
   > the unit test does not have any pom.xml: it's hard to guess what the code 
tries to represent from an end-user point of view
   
   assuming it is ambiguous:
   
   ```xml
   <project xmlns="http://maven.apache.org/POM/4.0.0"; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
     <modelVersion>4.0.0</modelVersion>
   
     <groupId>com.github.rmannibucau.test</groupId>
     <artifactId>foo</artifactId>
     <version>1.0.0-SNAPSHOT</version>
   
     <properties>
       <!-- this is what this PR was fixing by validating at eval time the 
presence of the property and not at model loading time -->
       
<project.build.outputTimestamp>${git.commit.time}</project.build.outputTimestamp>
     </properties>
   
      <!-- git-commit-id-plugin in initialize phase since there is nothing much 
before that phase for a maven build from plugins -->
   </project>
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to