[ 
https://issues.apache.org/jira/browse/MJAR-296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17833755#comment-17833755
 ] 

ASF GitHub Bot commented on MJAR-296:
-------------------------------------

slawekjaranowski commented on code in PR #67:
URL: https://github.com/apache/maven-jar-plugin/pull/67#discussion_r1550563632


##########
src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java:
##########
@@ -262,7 +294,7 @@ public File createArchive() throws MojoExecutionException {
                     getLog().warn("JAR will be empty - no content was marked 
for inclusion!");
                 }
             } else {
-                archiver.getArchiver().addDirectory(contentDirectory, 
getIncludes(), getExcludes());
+                
archiver.getArchiver().addFileSet(getFileSet(contentDirectory));

Review Comment:
   Maybe we can simple add next method `addDirectory` to Archiver with 
`addDefaultExcludes`?





> No way to suppress default excludes in maven-jar-plugin
> -------------------------------------------------------
>
>                 Key: MJAR-296
>                 URL: https://issues.apache.org/jira/browse/MJAR-296
>             Project: Maven JAR Plugin
>          Issue Type: Improvement
>    Affects Versions: 3.3.0
>            Reporter: G.Vaysman
>            Priority: Major
>         Attachments: jar-default-excludes.zip
>
>
> With the default excludes being expanded further (see 
> org.codehaus.plexus.util.AbstractScanner.{*}_DEFAULTEXCLUDES_{*}), a resource 
> directory **/ChangeSet/** will never be included in the JAR artifact.
> Some plugins (maven-resources-plugin, maven-assembly-plugin) already allow 
> suppressing the exclusion, but not the maven-jar-plugin. Code analysis of the 
> JarMojo -> DirectoryScanner call path confirms that there is no way to affect 
> the FileSet configuration. 
> Again, with ever expanding list of *_DEFAULTEXCLUDES,_* this, on our opinion, 
> is quite detrimental, and due to backward compatibility, changing 
> resource/package path (say, to ChangeSet2) is not an option. 
> I am attaching a very simple project that shows two things:
>  # The jar plugin skips adding the **/ChangeSet/** files
>  # The resources plugin is configured not to skip (addDefaultExcludes) and 
> behaves properly



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to