[ https://issues.apache.org/jira/browse/MPH-183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836433#comment-17836433 ]
ASF GitHub Bot commented on MPH-183: ------------------------------------ Giovds commented on code in PR #37: URL: https://github.com/apache/maven-help-plugin/pull/37#discussion_r1562100440 ########## src/main/java/org/apache/maven/plugins/help/DefaultInputLocationFormatter.java: ########## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.maven.plugins.help; + +import org.apache.maven.model.InputLocation; +import org.apache.maven.model.InputSource; +import org.codehaus.plexus.util.StringUtils; + +/** + * Maven 3.x-based implementation of {@link InputLocation.StringFormatter}. Review Comment: Agreed, we should probably change the name of the class and edit the JDocs. We would like to backport it to Maven 3, but initially want to make it work for Maven 4 first without breaking other versions. > Effective-pom + verbose should show import path to BOM dependencyManagement > --------------------------------------------------------------------------- > > Key: MPH-183 > URL: https://issues.apache.org/jira/browse/MPH-183 > Project: Maven Help Plugin > Issue Type: Improvement > Affects Versions: 3.2.0 > Reporter: Robert Scholte > Assignee: Maarten Mulders > Priority: Major > Attachments: mph-183-it.zip > > > The popular spring-boot makes a lot of use of BOMs. Using BOMs is a good > practice, but right now it is very hard to determine where > dependencyManagement dependencies and especially their versions are coming > from. > Instead of only showing only the final location (from the BOM POM), it should > also show the import path from the current project to that specific pom > (where is the BOM POM imported?). > This way it will be easier to figure out which dependency in which POM needs > to be upgraded: it's the version in the POM declaring the import of the BOM > POM, not the version in the imported BOM POM. -- This message was sent by Atlassian Jira (v8.20.10#820010)