[
https://issues.apache.org/jira/browse/MGPG-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836465#comment-17836465
]
ASF GitHub Bot commented on MGPG-125:
-------------------------------------
slawekjaranowski commented on code in PR #95:
URL: https://github.com/apache/maven-gpg-plugin/pull/95#discussion_r1562198479
##########
src/it/sign-release-best-practices-fail/pom.xml:
##########
@@ -0,0 +1,103 @@
+<?xml version="1.0" encoding="UTF-8"?>
+
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+ <modelVersion>4.0.0</modelVersion>
+
+ <groupId>org.apache.maven.its.gpg.sr</groupId>
+ <artifactId>test</artifactId>
+ <version>1.0</version>
+ <packaging>jar</packaging>
+
+ <description>
+ Tests the installation of a simple release JAR with an attached artifact
and its signatures.
+ </description>
+
+ <properties>
+ <maven.test.skip>true</maven.test.skip>
+ </properties>
+
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-compiler-plugin</artifactId>
+ <version>2.0.2</version>
Review Comment:
?
we can use `@version.maven-compiler-plugin@` properties for plugins versions
are defined in parent
> Due to default value of gpg.passphraseServerId, bestPractices=true will
> always fail
> -----------------------------------------------------------------------------------
>
> Key: MGPG-125
> URL: https://issues.apache.org/jira/browse/MGPG-125
> Project: Maven GPG Plugin
> Issue Type: Bug
> Affects Versions: 3.2.3
> Reporter: Benjamin Marwell
> Assignee: Tamas Cservenak
> Priority: Critical
> Fix For: 3.2.4
>
>
> Running gpg-plugin with best practices from the CLI, it will always fail
> since gpg.passphraseServerId does have a default value set.
> See:
> https://github.com/apache/maven-gpg-plugin/blob/master/src/main/java/org/apache/maven/plugins/gpg/AbstractGpgMojo.java#L140
> CC [~cstamas]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
