[ 
https://issues.apache.org/jira/browse/MCOMPILER-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836837#comment-17836837
 ] 

Slawomir Jaranowski commented on MCOMPILER-588:
-----------------------------------------------

[~midnighter] you should be able to close your PR by yourself

We can split such work for some a few smaller PRs.
We can have - simple unit test which can be migrated first.
We can use both JUnit4 and JUnit 5 i one project, so we ca do it step by step.

By the way thanks for the effort and contributions.
 

> JUnit4 test framework to JUnit5 migration
> -----------------------------------------
>
>                 Key: MCOMPILER-588
>                 URL: https://issues.apache.org/jira/browse/MCOMPILER-588
>             Project: Maven Compiler Plugin
>          Issue Type: Improvement
>            Reporter: Mikhail Deviatov
>            Priority: Major
>
> We have JUnit5 test framework for a long time. 
> It have modular architecture, good support in IDE and quite fast. It would be 
> good to add support JUnit5 to the project.
> The problem is that there are 2 library used for testing in project 
> *maven-plugin-testing-harness* and *org.eclipse.sisu.plexus* and they both 
> don't have JUnit5 support.
> I created a solution that overrides parts of code used derived and my own 
> implementation.
> Please take a look at it
> https://github.com/apache/maven-compiler-plugin/pull/233



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to