[ 
https://issues.apache.org/jira/browse/DOXIASITETOOLS-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836997#comment-17836997
 ] 

ASF GitHub Bot commented on DOXIASITETOOLS-329:
-----------------------------------------------

michael-o commented on code in PR #136:
URL: 
https://github.com/apache/maven-doxia-sitetools/pull/136#discussion_r1564900683


##########
doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java:
##########
@@ -498,6 +503,16 @@ protected Context createDocumentVelocityContext(
             context.put("doxiaSiteRendererVersion", 
DOXIA_SITE_RENDERER_VERSION);
         }
 
+        String doxiaSourcePath = docRenderingContext.getDoxiaSourcePath();
+        if (doxiaSourcePath != null) {
+            Path path = Paths.get(doxiaSourcePath);
+            try {
+                FileTime lastModifiedTime = Files.getLastModifiedTime(path);
+                context.put("lastModificationDate", new 
Date(lastModifiedTime.toMillis()));

Review Comment:
   This should be the canonical term: "lastModifiedDate"





> Expose lastModification date in addition to publishDate in Velocity Context
> ---------------------------------------------------------------------------
>
>                 Key: DOXIASITETOOLS-329
>                 URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-329
>             Project: Maven Doxia Sitetools
>          Issue Type: Improvement
>          Components: Site renderer
>            Reporter: Konrad Windszus
>            Assignee: Konrad Windszus
>            Priority: Major
>
> Currently only the published date (the same for the whole site) is available 
> in the Velocity context 
> (https://github.com/apache/maven-doxia-sitetools/blob/5fe4a4c5359e6a23b78f385e15f77767cadaee99/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java#L495).
>  It would be useful to also populate the lastModification date of the doxia 
> source file (if available). 
> That way one could expose a more useful date for end-users (as the publish 
> date rarely is equal to the date when a page was last touched). Obviously for 
> Sinks/Documents not based on Doxia source files this is not available.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to