hboutemy commented on PR #220: URL: https://github.com/apache/maven-shade-plugin/pull/220#issuecomment-2054182363
expectation of this PR is Reproducible Builds the test does not test reproducible builds, it tests what you think is the timestamp that should be in the zip, ignoring the fact that dos time in zip does not respect timezone code in plexus-archiver works for Reproducible Builds = build twice, eventually in different timezones, and get the same binary zip at the end one thing you can do is check what you get in a jar vs the project.build.outputTimestamp value that you defined in the pom.xml: you'll see an effect of this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
