[
https://issues.apache.org/jira/browse/MWRAPPER-124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17838410#comment-17838410
]
ASF GitHub Bot commented on MWRAPPER-124:
-----------------------------------------
gzm55 opened a new pull request, #133:
URL: https://github.com/apache/maven-wrapper/pull/133
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MWRAPPER) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line
and body.
- [ ] Format the pull request title like `[MWRAPPER-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `MWRAPPER-XXX` with the appropriate JIRA issue.
Best practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its clean
verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
port pr https://github.com/apache/maven-wrapper/pull/120
Test Method:
```bash
sed -n '/public class Downloader/,/\t}/p'
maven-wrapper-distribution/src/resources/only-mvnw > Downloader.java
jenv shell 21 ## or 1.7, 1.8, 11, 17
javac -version
javac Downloader.java -Xlint:all -Werror
```
Passed lint compile test with jdk 1.7, 1.8, 11, 17 and 21
> MavenWrapperDownloader uses new URL(String), which is deprecated in Java 21
> ---------------------------------------------------------------------------
>
> Key: MWRAPPER-124
> URL: https://issues.apache.org/jira/browse/MWRAPPER-124
> Project: Maven Wrapper
> Issue Type: Improvement
> Components: Maven Wrapper Scripts
> Affects Versions: 3.2.0
> Reporter: Russell Howe
> Assignee: Sylwester Lachiewicz
> Priority: Normal
> Fix For: 3.3.0
>
>
> {code:java}
> new URL(String)
> {code}
> was deprecated in Java 21:
> [https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/net/URL.html#constructor-deprecation]
> The Maven Wrapper docs say that Java 7+ is supported, so we can switch to
> using
> {code:java}
> URI.create(String).toURL()
> {code}
> instead, which is supported in Java 7
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
