[ 
https://issues.apache.org/jira/browse/MRESOLVER-540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17838705#comment-17838705
 ] 

ASF GitHub Bot commented on MRESOLVER-540:
------------------------------------------

cstamas commented on code in PR #474:
URL: https://github.com/apache/maven-resolver/pull/474#discussion_r1570983720


##########
maven-resolver-api/src/main/java/org/eclipse/aether/transfer/TransferResource.java:
##########
@@ -23,17 +23,43 @@
 
 import org.eclipse.aether.RequestTrace;
 
+import static java.util.Objects.requireNonNull;
+
 /**
  * Describes a resource being uploaded or downloaded by the repository system.
  */
 public final class TransferResource {
 
+    /**
+     * The type of this resource.
+     *
+     * @since 2.0.0
+     */
+    public enum ResourceType {

Review Comment:
   I kinda agree with you, moreover as these events are emitted ONLY by 
connector. For example, Transport API of Maven4 completely circumvents 
connector, and goes directly to transport... so yeah, due this (connector) type 
can really only be Artifact or Metadata





> TransferResource can and should tell more about transfer
> --------------------------------------------------------
>
>                 Key: MRESOLVER-540
>                 URL: https://issues.apache.org/jira/browse/MRESOLVER-540
>             Project: Maven Resolver
>          Issue Type: Improvement
>          Components: Resolver
>            Reporter: Tamas Cservenak
>            Assignee: Tamas Cservenak
>            Priority: Major
>             Fix For: 2.0.0, 2.0.0-alpha-11
>
>
> TransferEvent carries TransferResource, that tells only repoId, repoUrl, 
> path, etc (post-layout processed info) about the resource. Still, the event 
> could provide auxiliary info, as at resource creation point, everything is 
> there.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to