gnodet commented on code in PR #953:
URL: https://github.com/apache/maven-mvnd/pull/953#discussion_r1575782068
##########
client/src/main/java/org/mvndaemon/mvnd/client/DaemonParameters.java:
##########
@@ -491,16 +491,22 @@ private static List<CoreExtension>
readCoreExtensionsDescriptor(Path multiModule
private static List<CoreExtension>
filterCoreExtensions(List<CoreExtension> coreExtensions) {
Set<String> exclusions = new HashSet<>();
- String exclusionsString =
-
systemProperty(Environment.MVND_CORE_EXTENSIONS_EXCLUDE).asString();
+ String exclusionsString =
systemProperty(Environment.MVND_CORE_EXTENSIONS_EXCLUDE)
+ .asOptional()
Review Comment:
I think this should be:
```
String exclusionsString =
systemProperty(Environment.MVND_CORE_EXTENSIONS_EXCLUDE).orDefault().asString();
```
##########
client/src/main/java/org/mvndaemon/mvnd/client/DaemonParameters.java:
##########
@@ -491,16 +491,22 @@ private static List<CoreExtension>
readCoreExtensionsDescriptor(Path multiModule
private static List<CoreExtension>
filterCoreExtensions(List<CoreExtension> coreExtensions) {
Set<String> exclusions = new HashSet<>();
- String exclusionsString =
-
systemProperty(Environment.MVND_CORE_EXTENSIONS_EXCLUDE).asString();
+ String exclusionsString =
systemProperty(Environment.MVND_CORE_EXTENSIONS_EXCLUDE)
+ .asOptional()
+ .orElse(Environment.MVND_CORE_EXTENSIONS_EXCLUDE.getDefault());
if (exclusionsString != null) {
exclusions.addAll(Arrays.stream(exclusionsString.split(","))
.filter(e -> e != null && !e.trim().isEmpty())
.collect(Collectors.toList()));
}
- return coreExtensions.stream()
- .filter(e -> !exclusions.contains(e.getGroupId() + ":" +
e.getArtifactId()))
- .collect(Collectors.toList());
+ if (!exclusions.isEmpty()) {
+ LOG.info("Excluded extensions (GA): {}", exclusions);
Review Comment:
This should definitely not be part of the output, and not 4 times.
I'll revert this chunk, or log to debug at most.
##########
integration-tests/src/test/projects/maven-conf-ignore-ext/pom.xml:
##########
@@ -0,0 +1,27 @@
+<!--
+
+ Copyright 2019-2022 the original author or authors.
Review Comment:
Maybe remove the copyright ?
##########
integration-tests/src/test/projects/maven-conf-ignore-ext-def/pom.xml:
##########
@@ -0,0 +1,27 @@
+<!--
+
+ Copyright 2019-2022 the original author or authors.
Review Comment:
Remove the copyright ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
