[
https://issues.apache.org/jira/browse/MSHARED-1382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842656#comment-17842656
]
ASF GitHub Bot commented on MSHARED-1382:
-----------------------------------------
lrozenblyum commented on code in PR #74:
URL: https://github.com/apache/maven-invoker/pull/74#discussion_r1586330276
##########
src/test/java/org/apache/maven/shared/invoker/MavenCommandLineBuilderTest.java:
##########
@@ -299,6 +299,33 @@ public void testShouldSetUpdateSnapshotsFlagFromRequest() {
assertArgumentsPresent(cli, Collections.singleton("-U"));
}
+ // JUnit5: test methods don't need to be public
Review Comment:
Actually the `test` prefix is also redundant for `@Test` methods, yet here I
kept the project-wide convention...
> Maven-invoker: support '--no-snapshot-updates'
> ----------------------------------------------
>
> Key: MSHARED-1382
> URL: https://issues.apache.org/jira/browse/MSHARED-1382
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-invoker
> Affects Versions: maven-invoker-3.2.0
> Reporter: Leonid Rozenblyum
> Priority: Major
>
> Let's add support for *{{--no-snapshot-updates}}* in
> *{{org.apache.maven.shared.invoker.InvocationRequest}}*
>
> Currently *{{InvocationRequest}}* supports just the *{{-U}}* *mvn* option
> which is not enough: it's possible to force the snapshots update or keep
> default maven policy on this.
>
> But it's not possible to prevent snapshots updates which is highly desired
> under some circumstances (e.g. for CI reproducibility).
>
> NOTE: I may contribute a PR.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
