[ 
http://jira.codehaus.org/browse/DOXIA-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_103942
 ] 

Dennis Lundberg commented on DOXIA-131:
---------------------------------------

Here are the results of a little test I did with aptconvert

APT
{code}
  {Anchor}. Link to {{Anchor}}. Link to {{http://www.pixware.fr}}. 
  Link to {{{Anchor}showing alternate text}}.
  Link to {{{http://www.pixware.fr}Pixware home page}}.
  {-.:_myAnchor-_.:}
{code}

HTML
{code:xml}
<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html lang="en">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=Windows-1252">
<title></title>
</head>
<body>
<p><a id="anchor" name="anchor">Anchor</a>. Link to
<a href="#anchor">Anchor</a>. Link to
<a href="http://www.pixware.fr";>http://www.pixware.fr</a>. Link to
<a href="#anchor">showing alternate text</a>. Link to
<a href="http://www.pixware.fr";>Pixware home page</a>.
<a id="myanchor" name="myanchor">-.:_myAnchor-_.:</a></p></body>
</html>
{code}

As you can see characters are converted to lower case and "-_.:" are being 
stripped away.

I think that preserving case, like we do now, is the right thing to do. If we 
don't it might lead to duplicate ids which is illegal.

We should probably remove the "-_.:" characters though, as they don't have any 
value in an id attribute.

> HtmlTools.encodeId makes id lower case
> --------------------------------------
>
>                 Key: DOXIA-131
>                 URL: http://jira.codehaus.org/browse/DOXIA-131
>             Project: Maven Doxia
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.0-alpha-8
>            Reporter: Lukas Theussl
>            Assignee: Dennis Lundberg
>             Fix For: 1.0-beta-1
>
>
> HtmlTools.encodeId uses Character.toLowerCase to convert its argument to 
> lower case. I don't see the reason for that since upper case characters are 
> legal in id's (see http://www.w3.org/TR/html4/types.html#type-name ). In 
> particular, it's a problem with anchors/links in the xhtml sink (see DOXIA-47 
> ), especially if we want to create anchors from section names, to maintain 
> backward compatibility with m1. Is there a special reason for the toLowerCase 
> or can we remove it?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to