cstamas commented on code in PR #529:
URL: https://github.com/apache/maven-site/pull/529#discussion_r1608113695


##########
content/apt/pom.apt.vm:
##########
@@ -271,13 +271,20 @@ mvn install:install-file -Dfile=non-maven-proj.jar 
-DgroupId=some.group -Dartifa
   you browse the Maven central repository, you will notice that the 
classifiers <<<sources>>> and <<<javadoc>>> are used
   to deploy the project source code and API docs along with the packaged class 
files.
 
+  The classifier may also be derived from the <<type>> in case the related 
{{{/ref/current/maven-core/artifact-handlers.html} artifact handler}} defines 
one.
+
   * <<type>>:\
   Corresponds to the chosen dependency type. This defaults to <<<jar>>>. While 
it usually represents
-  the extension on the filename of the dependency, that is not always the 
case: a type can be mapped to a
+  the extension of the referenced artifact, that is not always the case: a 
type can be mapped to a
   different extension and a classifier. The type often corresponds to the 
packaging used, though this is
   also not always the case. Some examples are <<<jar>>>, <<<ejb-client>>> and 
<<<test-jar>>>:
   see {{{/ref/current/maven-core/artifact-handlers.html}default artifact 
handlers}} for a list. New types can be
   defined by plugins that set <<<extensions>>> to true, so this is not a 
complete list.
+  
+  In case there is an artifact handler defined there are <two> different ways 
of referencing the same dependency:

Review Comment:
   I find this very much mixed up and not quite comprehensive. @hboutemy 
   
   Issues:
   * by removal of "filename", the term "extension" is suddenly changing it's 
meaning (maven extension? this was my first thought while trying to comprehend 
the message)
   * did you maybe mix up the "former and latter"? 
   * I find this very confusing all in all. Type is type, why do you want to 
mixing here file extension?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to