[
https://issues.apache.org/jira/browse/SUREFIRE-2245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850752#comment-17850752
]
ASF GitHub Bot commented on SUREFIRE-2245:
------------------------------------------
michael-o commented on PR #737:
URL: https://github.com/apache/maven-surefire/pull/737#issuecomment-2139799953
@sormuras and @juliette-derancourt: Can you have a look at my changes in:
* surefire-its/src/test/resources/junit-4-5/pom.xml
* surefire-its/src/test/resources/junit5-suite/pom.xml
Maven Parent 42 updated to latest JUnit 1.10.x/5.10.x the use case started
to fail because of
https://github.com/junit-team/junit5/commit/b41ae69659e8dc3fa230f97d8a751d81e69d06d7.
Mixed dependencies, ABI incompat.
My questions to you both:
* Is that correct to do so in that case?
* We have documented in
`./maven-surefire-plugin/src/site/apt/examples/jpms.apt.vm`,
`./maven-surefire-plugin/src/site/apt/examples/junit-platform.apt.vm`,
`./maven-surefire-plugin/src/site/apt/usage.apt.vm` that only two deps need to
be supplied, in contrast to that what I have in those ITs. Should we modify
docs and require `junit-platform-engine` to be set as well?
> Upgrade to Parent 42 and Maven 3.6.3
> ------------------------------------
>
> Key: SUREFIRE-2245
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2245
> Project: Maven Surefire
> Issue Type: Dependency upgrade
> Reporter: Michael Osipov
> Assignee: Michael Osipov
> Priority: Major
> Fix For: 3.3.0
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
