[
https://issues.apache.org/jira/browse/MBUILDCACHE-87?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851310#comment-17851310
]
ASF GitHub Bot commented on MBUILDCACHE-87:
-------------------------------------------
AlexanderAshitkin commented on code in PR #146:
URL:
https://github.com/apache/maven-build-cache-extension/pull/146#discussion_r1623246723
##########
src/main/java/org/apache/maven/buildcache/checksum/DigestUtils.java:
##########
@@ -126,6 +126,10 @@ public static DigestItem dependency(HashChecksum checksum,
String key, String ha
return item("dependency", key, checksum.update(hash));
}
+ public static DigestItem pluginDependency(HashChecksum checksum, String
key, String hash) {
Review Comment:
I forgot to mention the `CacheDiff` class, which calculates the difference
between two cache records. The diff report should support the new item type.
> Checksum should consider plugin dependencies
> --------------------------------------------
>
> Key: MBUILDCACHE-87
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-87
> Project: Maven Build Cache Extension
> Issue Type: Improvement
> Reporter: Réda Housni Alaoui
> Priority: Major
> Labels: pull-request-available
>
> I have a multi module project where module A is used as a dependency of
> maven-dependency-plugin:unpack declared in module B.
> {{buildinfo.xml}} of module B does not consider module A as a dependency.
> Maybe something similar to
> https://github.com/apache/maven-build-cache-extension/blob/6eb05e61fdfa7be1ad44cf6afc13958b0c6ea4a6/src/main/java/org/apache/maven/buildcache/checksum/MavenProjectInput.java#L602
> should be added for plugin dependencies?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
