[
https://issues.apache.org/jira/browse/SUREFIRE-2245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851433#comment-17851433
]
ASF GitHub Bot commented on SUREFIRE-2245:
------------------------------------------
slawekjaranowski commented on code in PR #737:
URL: https://github.com/apache/maven-surefire/pull/737#discussion_r1623496947
##########
maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/AbstractSurefireMojoToolchainsTest.java:
##########
@@ -106,39 +94,17 @@ public void shouldFallthroughToBuildContextWhenNoSpecSet()
throws Exception {
assertThat(actual).isSameAs(expectedFromContext);
}
- @Test
- public void shouldReturnNoToolchainInMaven32() throws Exception {
- Toolchain toolchain = invokeMethod(
- AbstractSurefireMojo.class,
- "getToolchainMaven33x",
- MockToolchainManagerMaven32.class,
- new MockToolchainManagerMaven32(null),
- mock(MavenSession.class),
- emptyMap());
- assertNull(toolchain);
- }
-
@Test(expected = MojoFailureException.class)
- public void shouldThrowMaven33xToolchain() throws Exception {
- invokeMethod(
- AbstractSurefireMojo.class,
- "getToolchainMaven33x",
- MockToolchainManager.class,
- new MockToolchainManager(null, null),
- mock(MavenSession.class),
- emptyMap());
+ @Ignore
+ public void shouldThrowToolchain() throws Exception {
+ invokeMethod(AbstractSurefireMojo.class, "getToolchain");
}
@Test
- public void shouldGetMaven33xToolchain() throws Exception {
+ @Ignore
+ public void shouldGetToolchain() throws Exception {
Toolchain expected = mock(Toolchain.class);
- Toolchain actual = invokeMethod(
- AbstractSurefireMojo.class,
- "getToolchainMaven33x",
- MockToolchainManager.class,
- new MockToolchainManager(expected, null),
- mock(MavenSession.class),
- emptyMap());
+ Toolchain actual = invokeMethod(AbstractSurefireMojo.class,
"getToolchain");
Review Comment:
delete it
> Upgrade to Parent 42 and Maven 3.6.3
> ------------------------------------
>
> Key: SUREFIRE-2245
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2245
> Project: Maven Surefire
> Issue Type: Dependency upgrade
> Reporter: Michael Osipov
> Assignee: Michael Osipov
> Priority: Major
> Fix For: 3.3.0
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
