[
https://issues.apache.org/jira/browse/MSHARED-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851700#comment-17851700
]
ASF GitHub Bot commented on MSHARED-1407:
-----------------------------------------
slawekjaranowski commented on code in PR #125:
URL:
https://github.com/apache/maven-dependency-analyzer/pull/125#discussion_r1624656675
##########
src/main/java/org/apache/maven/shared/dependency/analyzer/asm/DependencyClassFileVisitor.java:
##########
@@ -26,11 +26,8 @@
import org.apache.maven.shared.dependency.analyzer.ClassFileVisitor;
import org.apache.maven.shared.dependency.analyzer.ClassesPatterns;
-import org.objectweb.asm.AnnotationVisitor;
-import org.objectweb.asm.ClassReader;
-import org.objectweb.asm.ClassVisitor;
-import org.objectweb.asm.FieldVisitor;
-import org.objectweb.asm.MethodVisitor;
+import org.apache.maven.shared.dependency.analyzer.DependencyUsage;
+import org.objectweb.asm.*;
Review Comment:
😄
##########
src/main/java/org/apache/maven/shared/dependency/analyzer/ProjectDependencyAnalysis.java:
##########
@@ -18,14 +18,8 @@
*/
package org.apache.maven.shared.dependency.analyzer;
-import java.util.Arrays;
-import java.util.Collections;
-import java.util.HashMap;
-import java.util.HashSet;
-import java.util.Iterator;
-import java.util.LinkedHashSet;
-import java.util.Map;
-import java.util.Set;
+import java.util.*;
Review Comment:
😄
##########
src/test/java/org/apache/maven/shared/dependency/analyzer/asm/DependencyVisitorTest.java:
##########
@@ -20,13 +20,7 @@
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
-import org.objectweb.asm.AnnotationVisitor;
-import org.objectweb.asm.Attribute;
-import org.objectweb.asm.FieldVisitor;
-import org.objectweb.asm.Label;
-import org.objectweb.asm.MethodVisitor;
-import org.objectweb.asm.Opcodes;
-import org.objectweb.asm.Type;
+import org.objectweb.asm.*;
Review Comment:
😄
> Track dependency usage by referencing classes
> ---------------------------------------------
>
> Key: MSHARED-1407
> URL: https://issues.apache.org/jira/browse/MSHARED-1407
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-dependency-analyzer
> Reporter: Jared Stehler
> Priority: Minor
>
> Improve upon the existing functionality which tracks which specific classes
> in a given dependency are used, by mapping those uses to which classes are
> using them.
> This is a resurrection of an older issue
> (https://issues.apache.org/jira/browse/MSHARED-632) / PR
> (https://github.com/apache/maven-dependency-analyzer/pull/20), which was
> closed due to lack of support for default interface methods prior to JDK8.
> Â
--
This message was sent by Atlassian Jira
(v8.20.10#820010)