mkolesnikov commented on code in PR #202:
URL: https://github.com/apache/maven-release/pull/202#discussion_r1627174008
##########
maven-release-manager/src/main/java/org/apache/maven/shared/release/transform/jdom2/JDomModel.java:
##########
@@ -192,14 +199,13 @@ public void setVersion(String version) {
project.addContent(index + 2, versionElement);
}
} else {
- if
(AbstractRewritePomsPhase.isCiFriendlyVersion(versionElement.getTextNormalize()))
{
+ if
(CiFriendlyVersion.isCiFriendlyVersion(versionElement.getTextNormalize())) {
// try to rewrite property if CI friendly expression is used
- String ciFriendlyPropertyName =
-
AbstractRewritePomsPhase.extractPropertyFromExpression(versionElement.getTextNormalize());
- Properties properties = getProperties();
- if (properties != null) {
- properties.setProperty(ciFriendlyPropertyName, version);
- }
+ CiFriendlyVersion.rewriteVersionAndProperties(
+ version,
+ versionElement.getTextNormalize(),
+ (JDomProperties) getProperties(),
+ mavenProject.getProperties());
Review Comment:
The code reverted back to using `System.getProperty` as it's the only way to
get `sha1` value from `mavenOpts`, see the integration test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
