michael-o commented on PR #1557: URL: https://github.com/apache/maven/pull/1557#issuecomment-2149767044
> If property `java.version` is in unexpected format, the activator throws NumberFormatEx, that in turn, is caught and reported by DefaultProfileSelector w/o any cause. > > These should be cleanly reported instead: report that `java.version` property is in "unexpected format", and also report why was there are failure to evaluate a properrty activation. > > Note1: Maven allows `-Djava.version` override, this is exactly what IT [MNG-3746](https://issues.apache.org/jira/browse/MNG-3746) exactly does, but the NumberFormatEx went unnoticed (was swallowed). > > Note2: This bug was revealed by #1555 as it reported the issue, and later "asserted error free log" which was not error-free. Hence, this bug was simply revealed by improved logging on unrelated issue. > > https://issues.apache.org/jira/browse/MNG-8142 That is the reason why user properties should *NEVER* be promoted to system properties. It causes chaos. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
