cstamas commented on code in PR #1555:
URL: https://github.com/apache/maven/pull/1555#discussion_r1630040851
##########
maven-core/src/main/java/org/apache/maven/internal/aether/LoggingRepositoryListener.java:
##########
@@ -96,12 +96,7 @@ public void artifactDescriptorInvalid(RepositoryEvent event)
{
buffer.append("The POM for ");
buffer.append(event.getArtifact());
buffer.append(" is invalid, transitive dependencies (if any) will not
be available");
-
- if (logger.isDebugEnabled()) {
- logger.warn(buffer + ": " + event.getException().getMessage());
- } else {
- logger.warn(buffer + ", enable debug logging for more details");
- }
+ logger.warn(buffer + ": " + event.getException().getMessage());
Review Comment:
In mean, it other words we _know_ from where even comes: from model builder
and will always come from model builder as this event is triggered from it when
it reports invalid model. So zero information (or zero value) has the stack
trace.
##########
maven-core/src/main/java/org/apache/maven/internal/aether/LoggingRepositoryListener.java:
##########
@@ -96,12 +96,7 @@ public void artifactDescriptorInvalid(RepositoryEvent event)
{
buffer.append("The POM for ");
buffer.append(event.getArtifact());
buffer.append(" is invalid, transitive dependencies (if any) will not
be available");
-
- if (logger.isDebugEnabled()) {
- logger.warn(buffer + ": " + event.getException().getMessage());
- } else {
- logger.warn(buffer + ", enable debug logging for more details");
- }
+ logger.warn(buffer + ": " + event.getException().getMessage());
Review Comment:
In mean, it other words we _know_ from where it comes: from model builder
and will always come from model builder as this event is triggered from it when
it reports invalid model. So zero information (or zero value) has the stack
trace.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
