[
https://issues.apache.org/jira/browse/MNG-8141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853108#comment-17853108
]
ASF GitHub Bot commented on MNG-8141:
-------------------------------------
cstamas commented on PR #1565:
URL: https://github.com/apache/maven/pull/1565#issuecomment-2154610405
This change is wrong, dropping it.
> Model Builder should not rely on "validity" of processed model
> --------------------------------------------------------------
>
> Key: MNG-8141
> URL: https://issues.apache.org/jira/browse/MNG-8141
> Project: Maven
> Issue Type: Improvement
> Components: Core
> Reporter: Tamas Cservenak
> Assignee: Tamas Cservenak
> Priority: Major
> Fix For: 4.0.0, 3.9.8, 4.0.0-beta-4
>
>
> ModelBuilder is component building models (POM + interpolating + parent
> inheritance and many many more things), but it should not rely that built
> model "was validated", as it MAY NOT been validated: for "furthest" models it
> builds, like a parent of a some-level-dependency we use MIN level of
> validation (minimal validation).
> Still, while the model builder builds, it relies on several aspects of the
> model, and it should ensure that the "output" (built model) is correct. Model
> Builder hence must be changed in way, that IF it detects any issue _during
> building_ of the model, and IF it appears with even slightest possibility
> that it cannot deliver "correct output", it must fail model building with
> proper messages.
> One typical case is when model building injects activated profiles (as they
> can deliver properties and extra plugins and what not) and activation code
> detects a "problem", like for example duplicated profile IDs being used (this
> IS catched by validation, but not on MIN level!), hence, model builder cannot
> guarantee that built model IS correct.
> Projects "stuck" on invalid models can use "escape hatch"
> {{-Dmaven.modelBuilder.failOnInvalidModel=false}} that reverts to original
> Maven behaviour, as reported in issue MNG-8131 for example.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
