[ 
https://issues.apache.org/jira/browse/MRELEASE-1144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853447#comment-17853447
 ] 

ASF GitHub Bot commented on MRELEASE-1144:
------------------------------------------

michael-o commented on PR #216:
URL: https://github.com/apache/maven-release/pull/216#issuecomment-2156217725

   @cstamas Can you help and have a look at the failure? subproject2 depends on 
subproject1 (in compile scope) which has junit in test scope, but some some 
reason that is dragged into subproject1 as test as well.
   The code which builds is:
   ```
       protected List<MavenProject> createReactorProjects(String sourcePath, 
String targetPath, String executionRoot)
               throws Exception {
           final Path testCaseRootFrom =
                   Paths.get(getBasedir(), 
"src/test/resources").resolve(Paths.get("projects", sourcePath));
   
           final Path testCaseRootTo = getWorkingDirectory(targetPath);
   
           // Recopy the test resources since they are modified in some tests
           Files.walkFileTree(testCaseRootFrom, new SimpleFileVisitor<Path>() {
   
               @Override
               public FileVisitResult visitFile(Path file, BasicFileAttributes 
attrs) throws IOException {
                   Path relPath = testCaseRootFrom.relativize(file);
   
                   if (!relPath.toFile().getName().startsWith("expected-")) {
                       
Files.createDirectories(testCaseRootTo.resolve(relPath).getParent());
   
                       Files.copy(file, testCaseRootTo.resolve(relPath), 
StandardCopyOption.REPLACE_EXISTING);
                   }
   
                   return FileVisitResult.CONTINUE;
               }
           });
   
           Path projectFile;
           if (executionRoot == null) {
               projectFile = testCaseRootTo.resolve("pom.xml");
           } else {
               projectFile = testCaseRootTo.resolve(Paths.get(executionRoot, 
"pom.xml"));
           }
   
           List<ArtifactRepository> repos = Collections.singletonList(
                   new DefaultArtifactRepository("central", 
getRemoteRepositoryURL(), new DefaultRepositoryLayout()));
   
           Repository repository = new Repository();
           repository.setId("central");
           repository.setUrl(getRemoteRepositoryURL());
   
           Profile profile = new Profile();
           profile.setId("profile");
           profile.addRepository(repository);
   
           ProjectBuildingRequest buildingRequest = new 
DefaultProjectBuildingRequest();
           buildingRequest.setLocalRepository(localRepository);
           buildingRequest.setRemoteRepositories(repos);
           buildingRequest.setPluginArtifactRepositories(repos);
           
buildingRequest.setRepositoryMerging(RepositoryMerging.REQUEST_DOMINANT);
           DefaultRepositorySystemSession repositorySession = new 
DefaultRepositorySystemSession();
           repositorySession.setLocalRepositoryManager(new 
SimpleLocalRepositoryManagerFactory()
                   .newInstance(repositorySession, new 
LocalRepository(localRepository.getBasedir())));
           buildingRequest.setRepositorySession(repositorySession);
           buildingRequest.addProfile(profile);
           
buildingRequest.setActiveProfileIds(Collections.singletonList(profile.getId()));
           buildingRequest.setResolveDependencies(true);
   
           List<ProjectBuildingResult> buildingResults =
                   
projectBuilder.build(Collections.singletonList(projectFile.toFile()), true, 
buildingRequest);
   
           List<MavenProject> reactorProjects = new ArrayList<>();
           for (ProjectBuildingResult buildingResult : buildingResults) {
               reactorProjects.add(buildingResult.getProject());
           }
   
           WorkspaceReader simpleReactorReader = new 
SimpleReactorWorkspaceReader(reactorProjects);
           repositorySession.setWorkspaceReader(simpleReactorReader);
   
           ProjectSorter sorter = new ProjectSorter(reactorProjects);
           reactorProjects = sorter.getSortedProjects();
   
           List<MavenProject> resolvedProjects = new 
ArrayList<>(reactorProjects.size());
           for (MavenProject project : reactorProjects) {
               MavenProject resolvedProject =
                       projectBuilder.build(project.getFile(), 
buildingRequest).getProject();
   
               // from LifecycleDependencyResolver
               if (resolvedProject.getDependencyArtifacts() == null) {
                   try {
                       resolvedProject.setDependencyArtifacts(
                               resolvedProject.createArtifacts(artifactFactory, 
null, null));
                   } catch (InvalidDependencyVersionException e) {
                       throw new LifecycleExecutionException(e);
                   }
               }
   
               // TODO .... understand why this is working ... :-)
               // why projectBuilder doesn't resolve and set in proper way 
DependencyArtifacts and Artifacts
               if (resolvedProject.getDependencyArtifacts().size()
                               >= resolvedProject.getArtifacts().size()
                       && 
resolvedProject.getDependencyArtifacts().stream().noneMatch(a -> a.getVersion() 
== null)) {
                   
resolvedProject.setArtifacts(resolvedProject.getDependencyArtifacts());
               }
   
               resolvedProjects.add(resolvedProject);
           }
           return resolvedProjects;
       }
   ```
   from `org.apache.maven.shared.release.phase.AbstractReleaseTestCase`.
   
   I am down to
   
![grafik](https://github.com/apache/maven-release/assets/573017/aac05ca7-257b-4b32-b719-67b6fafbeeab)




> Upgrade to Parent 42 and Maven 3.6.3
> ------------------------------------
>
>                 Key: MRELEASE-1144
>                 URL: https://issues.apache.org/jira/browse/MRELEASE-1144
>             Project: Maven Release Plugin
>          Issue Type: Dependency upgrade
>            Reporter: Michael Osipov
>            Assignee: Michael Osipov
>            Priority: Major
>             Fix For: next-release
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to