slawekjaranowski commented on code in PR #89:
URL: https://github.com/apache/maven-jar-plugin/pull/89#discussion_r1632295338


##########
src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java:
##########
@@ -351,6 +355,14 @@ public void execute() throws MojoExecutionException {
                     throw new MojoExecutionException("You have to use a 
classifier "
                             + "to attach supplemental artifacts to the project 
instead of replacing them.");
                 }
+
+                if (!"java"
+                        .equals(artifactHandlerManager
+                                
.getArtifactHandler(getProject().getPackaging())
+                                .getLanguage())) {
+                    getLog().warn(
+                                    "The project packaging language is NOT 
'java'; this is most probably not what you want");

Review Comment:
   What do you think to add a packaging name ... like:
   `The project packaging <packaging> language ...`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to