[ 
https://issues.apache.org/jira/browse/MRESOLVER-565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854708#comment-17854708
 ] 

ASF GitHub Bot commented on MRESOLVER-565:
------------------------------------------

cstamas opened a new pull request, #503:
URL: https://github.com/apache/maven-resolver/pull/503

   Rename classes to reflect what they are. These are "default implementations" 
used on new Session instances but usually not used in "real world".
   
   ---
   
   https://issues.apache.org/jira/browse/MRESOLVER-565




> Rename null selectors to more natural name
> ------------------------------------------
>
>                 Key: MRESOLVER-565
>                 URL: https://issues.apache.org/jira/browse/MRESOLVER-565
>             Project: Maven Resolver
>          Issue Type: Task
>          Components: Resolver
>            Reporter: Tamas Cservenak
>            Priority: Major
>             Fix For: 2.0.0, 2.0.0-beta-1
>
>
> The classes {{NullProxySelector}} and {{NullAuthenticationSelector}} are 
> badly named, in way that unlike other implementations of {{ProxySelector}} 
> and {{AuthenticationSelector}} implementations, they do not "find out" any 
> proxies or auth, they literally return "what remote repository instance 
> passed in has". Is more like "identity" or "passthrough" implementation, not 
> "null".



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to