[
https://issues.apache.org/jira/browse/MCOMPILER-529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17859486#comment-17859486
]
ASF GitHub Bot commented on MCOMPILER-529:
------------------------------------------
Bukama opened a new pull request, #245:
URL: https://github.com/apache/maven-compiler-plugin/pull/245
Created a draft for an additional note about the alternatives.
If you want have suggestions to improve it, please leave a comment and I
will change it.
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MCOMPILER) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line
and body.
- [x] Format the pull request title like `[MCOMPILER-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `MCOMPILER-XXX` with the appropriate JIRA issue.
Best practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [] You have run the integration tests successfully (`mvn -Prun-its clean
verify`).
[ERROR] The following builds failed:
[ERROR] * mcompiler-120\pom.xml
[ERROR] * MCOMPILER-346\pom.xml
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
> Improve the docs about usage 1.8 vs. 8 for source/target
> --------------------------------------------------------
>
> Key: MCOMPILER-529
> URL: https://issues.apache.org/jira/browse/MCOMPILER-529
> Project: Maven Compiler Plugin
> Issue Type: Improvement
> Affects Versions: 3.10.1
> Reporter: Karl Heinz Marbaise
> Priority: Minor
> Labels: up-for-grabs
>
> The current descriptions/docs only mentioned the usage of {{1.8}} for
> source/target. But it looks like I can use also {{8}} instead. But all the
> examples on the usage page etc. using {{1.8}}... even the error message tells
> me to do:
> {{code}}
> use -source 8 ...
> {{code}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
