michael-o commented on code in PR #1605: URL: https://github.com/apache/maven/pull/1605#discussion_r1671211174
########## maven-core/src/test/resources/project-dynamism/pom.xml: ########## @@ -1,6 +1,6 @@ <?xml version="1.0" encoding="UTF-8"?> -<project xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd"; - xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";> +<project + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";> <modelVersion>4.0.0</modelVersion> Review Comment: Is this change intended? all of these POMs were invalid because they aren't in the target namespace and if you don't sue the `xsi` NS why declare it? ########## maven-api-impl/src/main/java/org/apache/maven/internal/impl/DefaultToolchainsXmlFactory.java: ########## @@ -53,10 +52,6 @@ public PersistedToolchains read(@Nonnull XmlReaderRequest request) throws XmlRea throw new IllegalArgumentException("reader or inputStream must be non null"); } try { - InputSource source = null; - if (request.getModelId() != null || request.getLocation() != null) { - source = new InputSource(request.getModelId(), request.getLocation()); - } Review Comment: This is weird, source is never used? Was this found part of a new rule/detection? ########## pom.xml: ########## @@ -24,7 +24,7 @@ under the License. <groupId>org.apache.maven</groupId> <artifactId>maven-parent</artifactId> <!-- when upgrading parent, also upgrade maven-bom's parent --> - <version>42</version> + <version>43</version> Review Comment: Nothing else? No property removal/override? ########## maven-embedder/src/main/java/org/fusesource/jansi/Ansi.java: ########## @@ -25,10 +25,10 @@ * <a href="https://en.wikipedia.org/wiki/ANSI_escape_code#CSI_sequences";>ANSI escape sequences</a>. * * This class comes from Jansi and is provided for backward compatibility - * with maven-shared-utils, while Maven has migrated to JLine (into which Jansi has been merged + * wi§th maven-shared-utils, while Maven has migrated to JLine (into which Jansi has been merged Review Comment: Typo -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
