[
https://issues.apache.org/jira/browse/MRELEASE-1151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17865169#comment-17865169
]
Michael Osipov edited comment on MRELEASE-1151 at 7/11/24 5:39 PM:
-------------------------------------------------------------------
I need to admit that my CI-friendly knowledge is zero, especially on the
convoluted interplay between those three variables. (a) I cannot reasonably
decide what is right or wrong w/o better understanding the former and how this
works in Maven Release, (b) using system(!) properties
(https://github.com/apache/maven-release/pull/202/files#diff-a30ed9133fd726930d77b2ab0426c46a4bffc2294cbdd475671598f7f881bb3bR102-R111),
but not resolving for the others is very weird and feels wrong to me. For the
time being I will revert the offending commit and perform a fix release.
was (Author: michael-o):
I need to admit that my CI-friendly knowledge is zero, especially on the
convoluted interplay of those three variabled. (a) I cannot reasonably what is
right ro wrong w/o better understanding the former and how this works in Maven
Release, (b) using system(!) properties
(https://github.com/apache/maven-release/pull/202/files#diff-a30ed9133fd726930d77b2ab0426c46a4bffc2294cbdd475671598f7f881bb3bR102-R111),
but not resolving for the others is very weird to me. For the time being I
will revert the offending commit and perform a fix release.
> [REGRESSION] Maven Release Plugin fails to adjust version
> ---------------------------------------------------------
>
> Key: MRELEASE-1151
> URL: https://issues.apache.org/jira/browse/MRELEASE-1151
> Project: Maven Release Plugin
> Issue Type: Bug
> Components: prepare
> Affects Versions: 3.1.0
> Environment: Ubuntu 22.04.4 LTS x86_64
> Reporter: Basil Crow
> Assignee: Michael Osipov
> Priority: Blocker
> Fix For: 3.1.1
>
>
> h3. Steps to reproduce
> # Run {{git clone [https://github.com/jenkinsci/text-finder-plugin.git]}}
> # Using Java 17 and Maven 3.9.8, run {{mvn release:prepare
> -DpushChanges=false}}
> h3. Expected results
> {panel:title=Note}
> These are the _actual_ results with Maven Release Plugin 3.0.1.
> {panel}
> The {{[maven-release-plugin] prepare release}} commit adjusts
> {{<tag>${scmTag}</tag>}} to e.g. {{<tag>text-finder-1.29</tag>}} *and*
> adjusts {{<version>${revision}${changelist}</version>}} to e.g.
> {{{}<version>1.29</version>{}}}.
> h3. Actual results
> Starting with Maven Release Plugin 3.1.0, the {{[maven-release-plugin]
> prepare release}} commit still adjusts {{<tag>${scmTag}</tag>}} to e.g.
> {{{}<tag>text-finder-1.29</tag>{}}}, but it *fails to adjust*
> {{<version>${revision}${changelist}</version>}} to e.g.
> {{<version>1.29</version>}} as expected. After this, the release subsequently
> fails.
> h3. Evaluation
> This regression is caused by the changes to {{AbstractRewritePomsPhase}} made
> in MRELEASE-1109. When these changes are reverted, the issue is resolved.
> h3. Note
> This caused the weekly Jenkins core release to fail on July 2, 2024. We have
> downgraded Maven Release Plugin to 3.0.1 in order to restore stability to our
> releases.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
