[
https://issues.apache.org/jira/browse/MNG-6829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17867600#comment-17867600
]
ASF GitHub Bot commented on MNG-6829:
-------------------------------------
elharo commented on code in PR #154:
URL: https://github.com/apache/maven-site-plugin/pull/154#discussion_r1685728294
##########
src/main/java/org/apache/maven/plugins/site/deploy/AbstractDeployMojo.java:
##########
@@ -429,21 +429,21 @@ public static ProxyInfo getProxyInfo(Repository
repository, WagonManager wagonMa
String nonProxyHostPrefix = nonProxyHost.substring(0, pos);
String nonProxyHostSuffix = nonProxyHost.substring(pos + 1);
// prefix*
- if (StringUtils.isNotEmpty(nonProxyHostPrefix)
+ if ((nonProxyHostPrefix != null &&
!nonProxyHostPrefix.isEmpty())
Review Comment:
null checks aren't needed here. substring never returns null.
> Remove commons-lang3 dependency
> -------------------------------
>
> Key: MNG-6829
> URL: https://issues.apache.org/jira/browse/MNG-6829
> Project: Maven
> Issue Type: Sub-task
> Components: Bootstrap & Build
> Affects Versions: 3.6.3
> Reporter: Karl Heinz Marbaise
> Assignee: Karl Heinz Marbaise
> Priority: Minor
> Labels: close-pending
> Fix For: 4.0.0-alpha-7
>
> Attachments: dtPKn.xlsx
>
>
> Currently we use {{commons-lang3}} for the following classes
> * {{StringUtils}} can be replaced by usage of either {{plexus-utils}} or
> {{maven-shared-utils}} or as I tested with self implementation
> * {{SystemUtils}} is only used in some tests which can simply replaced by
> using JUnit Jupiter with all the support it has.
> * {{Validate}} is a precondition class which checks for parameters etc. can
> be implemented very easily (done already to see how it works). Later this
> could be made part of {{maven-shared-utils}}.
> * Currently the {{StringUtils.substringAfterLast( resourceName, "/" )}} is
> used in {{ConsoleMavenTransferListener}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
