[ 
https://issues.apache.org/jira/browse/MSHARED-1412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17871103#comment-17871103
 ] 

ASF GitHub Bot commented on MSHARED-1412:
-----------------------------------------

kwin opened a new pull request, #114:
URL: https://github.com/apache/maven-filtering/pull/114

   Backport to 3.x
   
   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
    - [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/MSHARED) filed 
          for the change (usually before you start working on it).  Trivial 
changes like typos do not 
          require a JIRA issue.  Your pull request should address just this 
issue, without 
          pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line 
and body.
    - [ ] Format the pull request title like `[MSHARED-XXX] - Fixes bug in 
ApproximateQuantiles`,
          where you replace `MSHARED-XXX` with the appropriate JIRA issue. Best 
practice
          is to use the JIRA issue title in the pull request title and in the 
first line of the 
          commit message.
    - [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
    - [ ] Run `mvn clean verify -Prun-its` to make sure basic checks pass. A 
more thorough check will 
          be performed on your pull request automatically.
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
    - [ ] I hereby declare this contribution to be licensed under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
    - [ ] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   




> Allow customization of Interpolator used for 
> BaseFilter.getDefaultFilterWrappers(...)
> -------------------------------------------------------------------------------------
>
>                 Key: MSHARED-1412
>                 URL: https://issues.apache.org/jira/browse/MSHARED-1412
>             Project: Maven Shared Components
>          Issue Type: Improvement
>          Components: maven-filtering
>    Affects Versions: maven-filtering-3.3.2
>            Reporter: Konrad Windszus
>            Assignee: Konrad Windszus
>            Priority: Major
>             Fix For: maven-filtering-4.0.0
>
>
> The default implementation of {{getDefaultFilterWrappers}} always returns a 
> single element list containing a {{Wrapper}} 
> (https://github.com/apache/maven-filtering/blob/9d528d0871d93e317ae21a4b6922cd795502364c/src/main/java/org/apache/maven/shared/filtering/BaseFilter.java#L178).
> That Wrapper's Interpolator should be customizable with regards to
> # 
> [ValueSource|https://github.com/codehaus-plexus/plexus-interpolation/blob/7f8e0920ea9b65e61457d2cd14ed31c7ffe67044/src/main/java/org/codehaus/plexus/interpolation/Interpolator.java#L33]
>  and
> # 
> [InterpolationPostProcessor|https://github.com/codehaus-plexus/plexus-interpolation/blob/7f8e0920ea9b65e61457d2cd14ed31c7ffe67044/src/main/java/org/codehaus/plexus/interpolation/Interpolator.java#L47]
> Currently neither the {{Interpolator}} nor the {{Wrapper}} class is exposed 
> or can be extended.
> As not every {{DefaultFilterInfo}} implementation necessarily relies on the 
> Plexus Interpolator this should probably be part of a dedicated interface 
> which is only implemented for {{Interpolator}} based default filters.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to