[
https://issues.apache.org/jira/browse/MJAVADOC-807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17874539#comment-17874539
]
ASF GitHub Bot commented on MJAVADOC-807:
-----------------------------------------
slawekjaranowski commented on code in PR #309:
URL:
https://github.com/apache/maven-javadoc-plugin/pull/309#discussion_r1720807439
##########
src/it/projects/MJAVADOC-498_modulepath/verify.groovy:
##########
@@ -17,5 +17,6 @@
* under the License.
*/
def log = new File( basedir, 'build.log').text
-
-assert log.count( " --module-path" ) == 3
+def count = log.count( " --module-path" )
+// depends on Maven version
+assert count == 2 || count == 3
Review Comment:
We have a `mavenVersion` property defined so we can add something like
```
assert mavenVersion.startWith('4') && count == x ||
mavenVersion.startWith('3') && count == y
```
##########
src/it/projects/MJAVADOC-498_mm_modulepath/invoker.properties:
##########
@@ -16,3 +16,4 @@
# under the License.
invoker.java.version = 9+
+invoker.goals=clean compile javadoc:javadoc
Review Comment:
clean is not necessary - invoker always clear project directory -
https://maven.apache.org/plugins/maven-invoker-plugin/integration-test-mojo.html#cloneClean
> Simplify IT for MJAVADOC-498
> ----------------------------
>
> Key: MJAVADOC-807
> URL: https://issues.apache.org/jira/browse/MJAVADOC-807
> Project: Maven Javadoc Plugin
> Issue Type: Task
> Components: javadoc
> Affects Versions: 3.8.0
> Reporter: Michael Osipov
> Assignee: Michael Osipov
> Priority: Major
> Fix For: 3.8.1
>
>
> While working on MJAVADOC-792 it turned out that the IT for MJAVADOC-498
> unnecessarily uses the package phase while a plain javadoc goal is sufficient
> and saves time. Move to plain goal.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
