cstamas commented on code in PR #67:
URL:
https://github.com/apache/maven-artifact-plugin/pull/67#discussion_r1808245388
##########
src/main/java/org/apache/maven/plugins/artifact/buildinfo/ReferenceBuildinfoUtil.java:
##########
@@ -59,17 +58,15 @@
* Utility to download reference artifacts and download or generate reference
buildinfo.
*/
class ReferenceBuildinfoUtil {
- private static final Set<String> JAR_TYPES;
+ private static final Set<String> JAR_EXTENSIONS;
static {
Set<String> types = new HashSet<>();
types.add("jar");
- types.add("test-jar");
types.add("war");
types.add("ear");
types.add("rar");
- types.add("maven-plugin");
Review Comment:
To be consistent, I'd rename `types` to `extensions` as later on, someone
will assume there is some mixup here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
