cstamas commented on code in PR #587:
URL: https://github.com/apache/maven-resolver/pull/587#discussion_r1813479603


##########
maven-resolver-transport-apache/src/main/java/org/eclipse/aether/transport/apache/ApacheTransporter.java:
##########
@@ -288,16 +288,20 @@ final class ApacheTransporter extends AbstractTransporter 
implements HttpTranspo
                 .register(AuthSchemes.KERBEROS, new KerberosSchemeFactory())
                 .build();
         SocketConfig socketConfig =
-                SocketConfig.custom().setSoTimeout(requestTimeout).build();
+                // the time to establish connection (low level)
+                SocketConfig.custom().setSoTimeout(connectTimeout).build();

Review Comment:
   SoTimeout is set on socket directly (so it works as Javadoc and you 
explain). The "socket timeout" is specific to HttpClient and would like to get 
some clarification about it @michael-o 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to