michael-o commented on code in PR #87:
URL:
https://github.com/apache/maven-doxia-converter/pull/87#discussion_r1837763199
##########
src/main/java/org/apache/maven/doxia/DefaultConverter.java:
##########
@@ -250,20 +258,86 @@ public void convert(InputFileWrapper input,
OutputFileWrapper output)
File relativeOutputDirectory = new File(
PathTool.getRelativeFilePath(input.getFile().getAbsolutePath(), f.getParent()));
convert(f, input.getEncoding(), input.getFormat(), output,
relativeOutputDirectory);
- cleanUp(input, f);
}
}
+ try {
+ postProcessAllFiles(output.getFormat());
+ } catch (InterruptedException e) {
+ Thread.currentThread().interrupt();
+ throw new ConverterException("Error post processing all files:
" + e.getMessage(), e);
+ } catch (IOException e) {
+ throw new ConverterException("Error post processing all files:
" + e.getMessage(), e);
+ }
Review Comment:
Won't both getMessage() and e be duplicated?
##########
src/main/java/org/apache/maven/doxia/DefaultConverter.java:
##########
@@ -438,6 +518,15 @@ private void convert(
"Successfully converted file \"{}\" to \"{}\"",
inputFile.getAbsolutePath(),
outputFile.getAbsolutePath());
+ try {
+ postProcessFile(inputFile, outputFile);
+ } catch (InterruptedException e) {
+ Thread.currentThread().interrupt();
+ throw new ConverterException("Error post processing files: " +
e.getMessage(), e);
+ } catch (IOException e) {
+ throw new ConverterException("Error post processing files: " +
e.getMessage(), e);
+ }
+ return outputFile;
Review Comment:
Same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
