[
https://issues.apache.org/jira/browse/DOXIATOOLS-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17897430#comment-17897430
]
ASF GitHub Bot commented on DOXIATOOLS-90:
------------------------------------------
michael-o commented on code in PR #87:
URL:
https://github.com/apache/maven-doxia-converter/pull/87#discussion_r1837763199
##########
src/main/java/org/apache/maven/doxia/DefaultConverter.java:
##########
@@ -250,20 +258,86 @@ public void convert(InputFileWrapper input,
OutputFileWrapper output)
File relativeOutputDirectory = new File(
PathTool.getRelativeFilePath(input.getFile().getAbsolutePath(), f.getParent()));
convert(f, input.getEncoding(), input.getFormat(), output,
relativeOutputDirectory);
- cleanUp(input, f);
}
}
+ try {
+ postProcessAllFiles(output.getFormat());
+ } catch (InterruptedException e) {
+ Thread.currentThread().interrupt();
+ throw new ConverterException("Error post processing all files:
" + e.getMessage(), e);
+ } catch (IOException e) {
+ throw new ConverterException("Error post processing all files:
" + e.getMessage(), e);
+ }
Review Comment:
Won't both getMessage() and e be duplicated?
##########
src/main/java/org/apache/maven/doxia/DefaultConverter.java:
##########
@@ -438,6 +518,15 @@ private void convert(
"Successfully converted file \"{}\" to \"{}\"",
inputFile.getAbsolutePath(),
outputFile.getAbsolutePath());
+ try {
+ postProcessFile(inputFile, outputFile);
+ } catch (InterruptedException e) {
+ Thread.currentThread().interrupt();
+ throw new ConverterException("Error post processing files: " +
e.getMessage(), e);
+ } catch (IOException e) {
+ throw new ConverterException("Error post processing files: " +
e.getMessage(), e);
+ }
+ return outputFile;
Review Comment:
Same here
> Optionally keep Git history on converted files
> ----------------------------------------------
>
> Key: DOXIATOOLS-90
> URL: https://issues.apache.org/jira/browse/DOXIATOOLS-90
> Project: Maven Doxia Tools
> Issue Type: New Feature
> Components: Doxia Converter
> Reporter: Konrad Windszus
> Assignee: Konrad Windszus
> Priority: Major
>
> Using [git mv|https://git-scm.com/docs/git-mv] allows to keep the file's
> history (although using the blame feature won't work as the line numbers are
> off after conversion).
> This is reasonable to use when the input files are managed with Git and the
> converted ones should still be.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
