elharo commented on code in PR #38:
URL:
https://github.com/apache/maven-scm-publish-plugin/pull/38#discussion_r1879997261
##########
.gitignore:
##########
@@ -1,18 +1,115 @@
+Here's an expanded version of your `.gitignore` file, which includes more
common patterns and file types to ignore for various development environments,
build tools, and operating systems:
+
+```gitignore
+# Directories
target/
+bin/
+out/
+bootstrap/
+
+# Eclipse
.project
.classpath
.settings/
-.svn/
-bin/
-# Intellij
+
+# IntelliJ
*.ipr
*.iml
-*~
-.idea
-out/
+*.iws
+.idea/
+
+# VS Code
+.vscode/
+
+# macOS
.DS_Store
-/bootstrap
+.AppleDouble
+.LSOverride
+
+# Windows
+Thumbs.db
+ehthumbs.db
+Desktop.ini
+$RECYCLE.BIN/
+*.cab
+*.lnk
+
+# Node.js
Review Comment:
we don't use node
##########
.gitignore:
##########
@@ -1,18 +1,115 @@
+Here's an expanded version of your `.gitignore` file, which includes more
common patterns and file types to ignore for various development environments,
build tools, and operating systems:
+
+```gitignore
+# Directories
target/
+bin/
+out/
+bootstrap/
+
+# Eclipse
.project
.classpath
.settings/
-.svn/
-bin/
-# Intellij
+
+# IntelliJ
*.ipr
*.iml
-*~
-.idea
-out/
+*.iws
+.idea/
+
+# VS Code
+.vscode/
+
+# macOS
.DS_Store
-/bootstrap
+.AppleDouble
+.LSOverride
+
+# Windows
+Thumbs.db
+ehthumbs.db
+Desktop.ini
+$RECYCLE.BIN/
+*.cab
+*.lnk
+
+# Node.js
+node_modules/
+npm-debug.log*
+yarn-debug.log*
+yarn-error.log*
+
+# Python
+__pycache__/
+*.py[cod]
+*$py.class
+.Python
+env/
+venv/
+ENV/
+env.bak/
+venv.bak/
+
+# Java
+*.class
+*.jar
+*.war
+*.ear
+*.javadoc
+
+# Build Tools
+*.log
+*.lock
+dist/
+build/
+*.mvn/
+target/
+
+# Gradle
Review Comment:
not gradle
##########
.gitignore:
##########
@@ -1,18 +1,115 @@
+Here's an expanded version of your `.gitignore` file, which includes more
common patterns and file types to ignore for various development environments,
build tools, and operating systems:
+
+```gitignore
+# Directories
target/
+bin/
+out/
+bootstrap/
+
+# Eclipse
.project
.classpath
.settings/
-.svn/
-bin/
-# Intellij
+
+# IntelliJ
*.ipr
*.iml
-*~
-.idea
-out/
+*.iws
+.idea/
+
+# VS Code
+.vscode/
+
+# macOS
.DS_Store
-/bootstrap
+.AppleDouble
+.LSOverride
+
+# Windows
+Thumbs.db
+ehthumbs.db
+Desktop.ini
+$RECYCLE.BIN/
+*.cab
+*.lnk
+
+# Node.js
+node_modules/
+npm-debug.log*
+yarn-debug.log*
+yarn-error.log*
+
+# Python
+__pycache__/
+*.py[cod]
+*$py.class
+.Python
+env/
+venv/
+ENV/
+env.bak/
+venv.bak/
+
+# Java
Review Comment:
we include some of these in some of our repos, mostly for tests
##########
src/it/issue-mscmpub-50/pom.xml:
##########
@@ -83,7 +104,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-project-info-reports-plugin</artifactId>
- <version>@projectInfoReportsPluginVersion@</version>
+ <version>3.4.1</version> <!-- Updated version -->
Review Comment:
we don't want to change to a fixed version from the variable; maybe update
the variable definition instead
##########
.gitignore:
##########
@@ -1,18 +1,115 @@
+Here's an expanded version of your `.gitignore` file, which includes more
common patterns and file types to ignore for various development environments,
build tools, and operating systems:
+
+```gitignore
+# Directories
target/
+bin/
+out/
+bootstrap/
+
+# Eclipse
.project
.classpath
.settings/
-.svn/
-bin/
-# Intellij
+
+# IntelliJ
*.ipr
*.iml
-*~
-.idea
-out/
+*.iws
+.idea/
+
+# VS Code
+.vscode/
+
+# macOS
.DS_Store
-/bootstrap
+.AppleDouble
+.LSOverride
+
+# Windows
+Thumbs.db
+ehthumbs.db
+Desktop.ini
+$RECYCLE.BIN/
+*.cab
+*.lnk
+
+# Node.js
+node_modules/
+npm-debug.log*
+yarn-debug.log*
+yarn-error.log*
+
+# Python
Review Comment:
we don't use python
##########
src/it/issue-mscmpub-50/pom.xml:
##########
@@ -75,6 +75,27 @@
</execution>
</executions>
</plugin>
+ <!-- Plugin to run the pre-check script -->
Review Comment:
this is something new
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
