elharo commented on code in PR #196:
URL: https://github.com/apache/maven-release/pull/196#discussion_r1882003514
##########
maven-release-manager/src/test/java/org/apache/maven/shared/release/phase/MapVersionsPhaseTest.java:
##########
@@ -2447,11 +2448,44 @@ public void
testUpdateDevelopmentInvalidDefaultDevelopmentVersion_NonInteractive
}
}
+ @Test
+ public void testSimulateRelease_CheckModificationExcludes() throws
Exception {
+ // verify
+ MapReleaseVersionsPhase phase =
+ new MapReleaseVersionsPhase(scmRepositoryConfigurator,
mockPrompter, versionPolicies);
+
+ List<MavenProject> reactorProjects =
Collections.singletonList(createProjectWithPomFile("artifactId", "1.2"));
+
+ ReleaseDescriptorBuilder builder = new ReleaseDescriptorBuilder();
+
builder.setCheckModificationExcludes(Collections.singletonList("**/pom1.xml"));
+
+ // test
+ phase.simulate(ReleaseUtils.buildReleaseDescriptor(builder), new
DefaultReleaseEnvironment(), reactorProjects);
+
+ // verify
+ assertNull(
Review Comment:
When would this not be null? Is there a test for that case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
