[
https://issues.apache.org/jira/browse/MASSEMBLY-939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17905195#comment-17905195
]
ASF GitHub Bot commented on MASSEMBLY-939:
------------------------------------------
elharo commented on code in PR #32:
URL:
https://github.com/apache/maven-assembly-plugin/pull/32#discussion_r1882181475
##########
src/test/java/org/apache/maven/plugins/assembly/filter/SimpleAggregatingDescriptorHandlerTest.java:
##########
@@ -0,0 +1,99 @@
+package org.apache.maven.plugins.assembly.filter;
+
+/*
Review Comment:
license above package
##########
src/main/java/org/apache/maven/plugins/assembly/archive/archiver/AssemblyProxyArchiver.java:
##########
@@ -784,7 +785,15 @@ private boolean acceptFile( final File inputFile )
{
if ( selectors != null )
{
- final FileInfo fileInfo = new DefaultFileInfo( inputFile );
+ final FileInfo fileInfo;
Review Comment:
use a larger try block, don't split initialization and declaration
##########
src/test/java/org/apache/maven/plugins/assembly/filter/AbstractLineAggregatingHandlerTest.java:
##########
@@ -0,0 +1,114 @@
+package org.apache.maven.plugins.assembly.filter;
+
+/*
Review Comment:
License above package
> META-INF services aggregating invalidates updateOnly
> ----------------------------------------------------
>
> Key: MASSEMBLY-939
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-939
> Project: Maven Assembly Plugin
> Issue Type: Bug
> Reporter: Robert James Oxspring
> Priority: Major
>
> When aggregating META-INF/services/ entries the merged entry effectively has
> a lastModified date of now. Consequently the <updateOnly> logic always sees
> the sources as newer than the destination, and triggers unnecessary
> overwriting.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
